Remove the experimental prominent add to app launcher flow.

Remove the experimental prominent add to app launcher flow.

A different approach will be taken, where the add to app launcher flow
is initiated from the page info dialog.

BUG=378171
Committed: https://crrev.com/e8e02e51f00b08f61068f0d3de61442cc68a5c57
Cr-Commit-Position: refs/heads/master@{#291866}

[calamity, 2014-08-21 06:37:31]

lgtm w/ nit.

https://codereview.chromium.org/488373002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (left):

https://codereview.chromium.org/488373002/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1555:
IDS_FLAGS_ENABLE_PROMINENT_URL_APP_FLOW_DESCRIPTION,
These should be removed from generated_resources.grd.

[benwells, 2014-08-21 06:54:05]

pkasting: c/b/ui/views/location_bar (just deletions)
asvitkine: tools/metrics

I'm not sure if I should remove the histogram yet or not.

[Alexei Svitkine (slow), 2014-08-21 13:39:21]

https://codereview.chromium.org/488373002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/488373002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:43798: -  <int value="1095061640"
label="enable-prominent-url-app-flow"/>
Please don't remove entries from here, so that old UMA data can still be
decoded. You can annotate it as obsolete, if you want, though.

[Peter Kasting, 2014-08-22 00:36:39]

LGTM

[benwells, 2014-08-22 01:35:27]

https://codereview.chromium.org/488373002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/488373002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:43798: -  <int value="1095061640"
label="enable-prominent-url-app-flow"/>
On 2014/08/21 13:39:20, Alexei Svitkine wrote:
> Please don't remove entries from here, so that old UMA data can still be
> decoded. You can annotate it as obsolete, if you want, though.

I can't see any other flags that have been marked as obsolete, so I'll just
leave it in.

[benwells, 2014-08-22 01:35:33]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-08-22 01:40:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benwells@chromium.org/488373002/40001

[commit-bot: I haz the power, 2014-08-22 03:34:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-22 03:37:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 03:37:02]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[benwells, 2014-08-22 03:47:02]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-08-22 03:48:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benwells@chromium.org/488373002/40001

[commit-bot: I haz the power, 2014-08-22 04:27:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-22 04:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 04:34:03]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[benwells, 2014-08-22 04:47:51]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-08-22 04:48:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benwells@chromium.org/488373002/40001

[commit-bot: I haz the power, 2014-08-22 05:21:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[benwells, 2014-08-22 05:35:14]

The CQ bit was unchecked by benwells@chromium.org

[benwells, 2014-08-25 22:46:42]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-08-25 22:48:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benwells@chromium.org/488373002/40001

[commit-bot: I haz the power, 2014-08-25 23:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 23:00:58]

Failed to apply patch for chrome/app/generated_resources.grd:
While running git apply --index -p1;
  error: patch failed: chrome/app/generated_resources.grd:12983
  error: chrome/app/generated_resources.grd: patch does not apply

Patch:       chrome/app/generated_resources.grd
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd
b/chrome/app/generated_resources.grd
index
9732bb17dc4a01b19728ed1d39916cbc58bedbba..bb90c7fbde9e00e4cce013a602992c86d27a1972
100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -6393,12 +6393,6 @@ Keep your key file in a safe place. You will need it to
create new versions of y
           If enabled, transitions during first-run tutorial are animated.
         </message>
       </if>
-      <message name="IDS_FLAGS_ENABLE_PROMINENT_URL_APP_FLOW_NAME" desc="Name
of the flag to enable the prominent URL app creation flow.">
-        Enable the prominent URL app creation flow.
-      </message>
-      <message name="IDS_FLAGS_ENABLE_PROMINENT_URL_APP_FLOW_DESCRIPTION"
desc="Description for the flag to enable the prominent URL app creation flow.">
-        Enables a more prominent way to create URL apps. Does nothing if
Streamlined Hosted Apps is not enabled.
-      </message>
       <message name="IDS_FLAGS_ENABLE_STREAMLINED_HOSTED_APPS_NAME" desc="Name
of the flag to enable streamlined hosted apps.">
         Enable experimental streamlined hosted apps.
       </message>
@@ -12983,7 +12977,7 @@ Some features may be unavailable.  Please check that the
profile exists and you
     </message>
     <message name="IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL_FOR_REAUTH" desc="The
text for the choice to not allow autofilling for reauth pages in about:flags">
       Disallow for reauth
-    </message>    
+    </message>
 
     <!-- Update Recommended dialog -->
     <if expr="not chromeos">

[benwells, 2014-08-26 05:43:42]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-08-26 05:45:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benwells@chromium.org/488373002/60001

[commit-bot: I haz the power, 2014-08-26 08:07:04]

Committed patchset #4 (60001) as ace3b1f6ac9ae5e121ff6bcbd2e8f3d99e383679

[commit-bot: I haz the power, 2014-09-10 02:41:23]

Patchset 4 (id:??) landed as
https://crrev.com/e8e02e51f00b08f61068f0d3de61442cc68a5c57
Cr-Commit-Position: refs/heads/master@{#291866}