Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 488363003: Correctly forward-declare inline function headers in generic-node.h (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Correctly forward-declare inline function headers in generic-node.h R=bmeurer@chromium.org, jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/compiler/generic-node.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/node-properties-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-08-25 06:52:58 UTC) #1
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-08-25 06:54:06 UTC) #2
Yang
6 years, 3 months ago (2014-08-25 06:57:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23331 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698