Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: extensions/renderer/resources/serial_service.js

Issue 488363002: Implement the host side of serial connection I/O on data pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/serial_service.js
diff --git a/extensions/renderer/resources/serial_service.js b/extensions/renderer/resources/serial_service.js
index 00d137b1ea1cac14226803db8fd829650b2c83c7..ecba0eccf7a02c8caa653a0c539e40c0d0327b6f 100644
--- a/extensions/renderer/resources/serial_service.js
+++ b/extensions/renderer/resources/serial_service.js
@@ -122,7 +122,15 @@ define('serial_service', [
options = options || {};
var serviceOptions = getServiceOptions(options);
var pipe = core.createMessagePipe();
- service.connect(path, serviceOptions, pipe.handle0);
+ var sendPipe = core.createMessagePipe();
+ var receivePipe = core.createMessagePipe();
+ service.connect(path,
+ serviceOptions,
+ pipe.handle0,
+ sendPipe.handle0,
+ receivePipe.handle0);
+ core.close(sendPipe.handle1);
raymes 2014/08/22 04:57:43 Make a note that you will be implementing this in
Sam McNally 2014/08/22 08:12:12 Done.
+ core.close(receivePipe.handle1);
var router = new routerModule.Router(pipe.handle1);
var connection = new serialMojom.ConnectionProxy(router);
return connection.getInfo().then(convertServiceInfo).then(

Powered by Google App Engine
This is Rietveld 408576698