Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 488353004: Whitelist the new hotwording component extension for media capture. (Closed)

Created:
6 years, 4 months ago by Anand Mistry (off Chromium)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Whitelist the new hotwording component extension for media capture. Stolen from https://codereview.chromium.org/118373003 BUG=397019 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291283

Patch Set 1 #

Patch Set 2 : Add to JSON. #

Total comments: 2

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/media/media_capture_devices_dispatcher.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Anand Mistry (off Chromium)
6 years, 4 months ago (2014-08-21 05:50:52 UTC) #1
benwells
amistry: we have extensions owners in sydney :) lgtm with a comment added. miket: no ...
6 years, 4 months ago (2014-08-21 05:55:32 UTC) #2
Anand Mistry (off Chromium)
https://codereview.chromium.org/488353004/diff/20001/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/488353004/diff/20001/chrome/common/extensions/api/_permission_features.json#newcode133 chrome/common/extensions/api/_permission_features.json:133: "62CCAAD339E6451BBF97C4BBDF758E934A05AD0B" On 2014/08/21 05:55:32, benwells wrote: > Can you ...
6 years, 4 months ago (2014-08-21 06:07:57 UTC) #3
tommi (sloooow) - chröme
lgtm
6 years, 4 months ago (2014-08-21 12:20:10 UTC) #4
Anand Mistry (off Chromium)
The CQ bit was checked by amistry@chromium.org
6 years, 4 months ago (2014-08-21 21:19:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amistry@chromium.org/488353004/40001
6 years, 4 months ago (2014-08-21 21:27:21 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 22:38:37 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 22:45:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8212)
6 years, 4 months ago (2014-08-21 22:45:22 UTC) #9
Anand Mistry (off Chromium)
The CQ bit was checked by amistry@chromium.org
6 years, 4 months ago (2014-08-21 23:03:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amistry@chromium.org/488353004/40001
6 years, 4 months ago (2014-08-21 23:09:37 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (40001) as 291283
6 years, 4 months ago (2014-08-22 00:58:37 UTC) #12
miket_OOO
6 years, 4 months ago (2014-08-25 22:10:29 UTC) #13
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698