Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm - Issue 488353003: Specify clip rects when drawing Mac native widgets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

Issue 488353003: Specify clip rects when drawing Mac native widgets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporate review feedbac Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

diff --git a/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm b/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

index 0649932408f3a3ce4060b9fcc4530d5954d07a13..49fa2e168a5cf0a787d514cea37edd6922164f9e 100644

--- a/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

+++ b/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

@@ -135,7 +135,7 @@ bool ScrollbarThemeMacNonOverlayAPI::paint(ScrollbarThemeClient* scrollbar, Grap

}

// Draw thumbless.

- gfx::SkiaBitLocker bitLocker(drawingContext->canvas());

+ gfx::SkiaBitLocker bitLocker(drawingContext->canvas(), scrollbar->frameRect());

CGContextRef cgContext = bitLocker.cgContext();

HIThemeDrawTrack(&trackInfo, 0, cgContext, kHIThemeOrientationNormal);

« Source/platform/mac/ThemeMac.mm ('K') | « Source/platform/mac/ThemeMac.mm ('k') | Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm » ('j') | no next file with comments »