Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 488343003: Update valgrind suppression file for new FontConfig code. (Closed)

Created:
6 years, 3 months ago by bungeman-skia
Modified:
6 years, 3 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update valgrind suppression file for new FontConfig code. BUG=skia:2879 Committed: https://skia.googlesource.com/skia/+/50119fa861eaebe9f32e7131d7655f1471948cf9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M tools/valgrind.supp View 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bungeman-skia
bungeman@google.com changed reviewers: + djsollen@google.com, mtklein@google.com
6 years, 3 months ago (2014-08-26 19:53:12 UTC) #1
bungeman-skia
See Chromium's suppression file for some existing background. Essentially, FcPatternObjectInsertElt uses both malloc and realloc ...
6 years, 3 months ago (2014-08-26 19:53:13 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 3 months ago (2014-08-26 20:39:05 UTC) #3
mtklein
lgtm
6 years, 3 months ago (2014-08-26 20:39:06 UTC) #4
djsollen
lgtm
6 years, 3 months ago (2014-08-26 20:39:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/488343003/1
6 years, 3 months ago (2014-08-26 20:40:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 20:48:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 50119fa861eaebe9f32e7131d7655f1471948cf9

Powered by Google App Engine
This is Rietveld 408576698