Issue 48833007: Revise pub build patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48833007: Revise pub build patch. (Closed)

Created:
7 years, 1 month ago by Bob Nystrom

Modified:
7 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/command/build.dart	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
	M	sdk/lib/_internal/pub/test/build/compiles_dart_entrypoints_to_dart_and_js_test.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

nweiz

I'd still like to see [Future.forEach] changed to [Future.wait], but otherwise lgtm.

7 years, 1 month ago (2013-10-29 00:50:26 UTC) #2

Bob Nystrom

7 years, 1 month ago (2013-10-29 19:40:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r29481 (presubmit successful).