Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: sdk/lib/_internal/pub/test/dependency_override_test.dart

Issue 488323002: Make servePackages's contents argument saner. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/dependency_override_test.dart
diff --git a/sdk/lib/_internal/pub/test/dependency_override_test.dart b/sdk/lib/_internal/pub/test/dependency_override_test.dart
index fcbb3bc276c05a0dbb20331fc7b643aeb0eb9fde..4e47e24f6a9aafa2da9d4277b47ae6ca00fe4d0c 100644
--- a/sdk/lib/_internal/pub/test/dependency_override_test.dart
+++ b/sdk/lib/_internal/pub/test/dependency_override_test.dart
@@ -11,11 +11,11 @@ main() {
initConfig();
forBothPubGetAndUpgrade((command) {
integration("chooses best version matching override constraint", () {
- servePackages([
- packageMap("foo", "1.0.0"),
- packageMap("foo", "2.0.0"),
- packageMap("foo", "3.0.0")
- ]);
+ servePackages((builder) {
+ builder.serve("foo", "1.0.0");
+ builder.serve("foo", "2.0.0");
+ builder.serve("foo", "3.0.0");
+ });
d.dir(appPath, [
d.pubspec({
@@ -37,9 +37,9 @@ main() {
});
integration("treats override as implicit dependency", () {
- servePackages([
- packageMap("foo", "1.0.0")
- ]);
+ servePackages((builder) {
+ builder.serve("foo", "1.0.0");
+ });
d.dir(appPath, [
d.pubspec({
@@ -58,12 +58,14 @@ main() {
});
integration("ignores other constraints on overridden package", () {
- servePackages([
- packageMap("foo", "1.0.0"),
- packageMap("foo", "2.0.0"),
- packageMap("foo", "3.0.0"),
- packageMap("bar", "1.0.0", {"foo": "5.0.0-nonexistent"})
- ]);
+ servePackages((builder) {
+ builder.serve("foo", "1.0.0");
+ builder.serve("foo", "2.0.0");
+ builder.serve("foo", "3.0.0");
+ builder.serve("bar", "1.0.0", pubspec: {
+ "dependencies": {"foo": "5.0.0-nonexistent"}
+ });
+ });
d.dir(appPath, [
d.pubspec({
@@ -86,10 +88,10 @@ main() {
});
integration("warns about overridden dependencies", () {
- servePackages([
- packageMap("foo", "1.0.0"),
- packageMap("bar", "1.0.0")
- ]);
+ servePackages((builder) {
+ builder.serve("foo", "1.0.0");
+ builder.serve("bar", "1.0.0");
+ });
d.dir("baz", [
d.libDir("baz"),

Powered by Google App Engine
This is Rietveld 408576698