sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart - Issue 488323002: Make servePackages's contents argument saner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart

Issue 488323002: Make servePackages's contents argument saner. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/pub/test/deps_test.dart ('K') | « sdk/lib/_internal/pub/test/global/run/unknown_package_test.dart ('k') | sdk/lib/_internal/pub/test/hosted/offline_test.dart » ('j') | sdk/lib/_internal/pub/test/serve_packages.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart

diff --git a/sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart b/sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart

index 60be82ffbe132f27a1ecb3b1c531974b39d6933a..56550587e183885680cb828ea0417be649bf3908 100644

--- a/sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart

+++ b/sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart

@@ -14,7 +14,7 @@ main() {

forBothPubGetAndUpgrade((command) {

integration('fails gracefully if the package does not exist', () {

- servePackages([]);

+ servePackages((_) {});

d.appDir({"foo": "1.2.3"}).create();