Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/pub/test/cache/add/package_not_found_test.dart

Issue 488323002: Make servePackages's contents argument saner. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/test/cache/add/no_matching_version_test.dart ('k') | sdk/lib/_internal/pub/test/cache/repair/handles_failure_test.dart » ('j') | sdk/lib/_internal/pub/test/deps_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/cache/add/package_not_found_test.dart
diff --git a/sdk/lib/_internal/pub/test/cache/add/package_not_found_test.dart b/sdk/lib/_internal/pub/test/cache/add/package_not_found_test.dart
index d1bacfcf030bab9f3a2c39e631f9b41de0671435..22dc7e924a48d0e059afe2ad0e167cfec92ab26e 100644
--- a/sdk/lib/_internal/pub/test/cache/add/package_not_found_test.dart
+++ b/sdk/lib/_internal/pub/test/cache/add/package_not_found_test.dart
@@ -10,7 +10,7 @@ import '../../test_pub.dart';
main() {
initConfig();
integration('fails if the package cound not be found on the source', () {
- servePackages([]);
+ servePackages((_) {});
Bob Nystrom 2014/08/21 16:44:17 Make the builder optional?
nweiz 2014/08/21 18:28:51 It would have to be named, which makes the normal
schedulePub(args: ["cache", "add", "foo"],
error: new RegExp(r"Could not find package foo at http://.*"),
« no previous file with comments | « sdk/lib/_internal/pub/test/cache/add/no_matching_version_test.dart ('k') | sdk/lib/_internal/pub/test/cache/repair/handles_failure_test.dart » ('j') | sdk/lib/_internal/pub/test/deps_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698