Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/check_git_config.py

Issue 488313003: Do not suggest to replace .DEPS.git with DEPS. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/check_git_config.py
diff --git a/tools/check_git_config.py b/tools/check_git_config.py
index 51b13017882f645b5426f6d9c439b7d21ec87cd6..2b5fe58dafd29bdf7bba465b83547fcc6ad760cb 100755
--- a/tools/check_git_config.py
+++ b/tools/check_git_config.py
@@ -385,7 +385,9 @@ def check_gclient_config(conf):
'managed': conf['gclient_managed'] or False,
'url': conf['gclient_url'],
}
- good = GOOD_GCLIENT_SOLUTION
+ # After depot_tools r291592 both DEPS and .DEPS.git are valid.
+ good = GOOD_GCLIENT_SOLUTION.copy()
+ good['deps_file'] = current['deps_file']
if current == good:
return
# Show big warning if url or deps_file is wrong.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698