chrome/browser/resources/extensions/extension_options_overlay.css - Issue 488293003: Embedded Extension Options: Improve the overlay popup UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions/extension_options_overlay.css

Issue 488293003: Embedded Extension Options: Improve the overlay popup UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/resources/extensions/extension_options_overlay.html » ('j') | chrome/browser/resources/extensions/extension_options_overlay.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /* Copyright 2014 The Chromium Authors. All rights reserved.	1 /* Copyright 2014 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file. */	3 * found in the LICENSE file. */

4	4

5 #extension-options-overlay {	5 #extension-options-overlay {

6 overflow: hidden;	6 overflow: hidden;

7 }	7 }

	8

	9 #extension-options-overlay .close-button {

	10 z-index: 2;

	11 }

	12

	13 #extension-options-overlay-header {

	14 align-items: center;

	15 box-shadow: 0 0 10px 4px rgba(0, 0, 0, 0.1);

	16 display: flex;

	17 position: relative;

	18 z-index: 1;
	not at google - send to devlin 2014/08/22 22:31:00 Why the z-indices? Why the z-indices? ericzeng 2014/08/23 00:14:49 I needed a z-index on this div so that I could lin Show quoted text On 2014/08/22 22:31:00, kalman wrote: > Why the z-indices? I needed a z-index on this div so that I could line up the heading text and the icon. Since close-button also has a z-index of 1 I had to make my close-button have a z-index of 2.
	19 }

	20

	21 #extension-options-overlay-header h1 {

	22 padding-left: 8px;

	23 }

	24

	25 #extension-options-overlay-icon {

	26 display: inline-block;

	27 float: left;
	not at google - send to devlin 2014/08/22 22:31:00 Why float? Why float? ericzeng 2014/08/23 00:14:49 Also needed it to align the heading and icon Show quoted text On 2014/08/22 22:31:00, kalman wrote: > Why float? Also needed it to align the heading and icon
	28 padding-bottom: 8px;

	29 padding-left: 8px;

	30 padding-top: 8px;

	31 }

	32

	33 #extension-options-overlay-icon img {
	not at google - send to devlin 2014/08/22 22:31:00 Why meddling with the display everywhere? Why meddling with the display everywhere? ericzeng 2014/08/23 00:14:49 Alignment aarrrrgghhh Show quoted text On 2014/08/22 22:31:00, kalman wrote: > Why meddling with the display everywhere? Alignment aarrrrgghhh
	34 display: block;

	35 height: 32px;

	36 width: 32px;

	37 }

	38

	39 #extension-options-overlay-title {

	40 display: inline-block;

	41 vertical-align: top;

	42 }
	not at google - send to devlin 2014/08/22 22:31:00 I should come around to your desk and we can verif I should come around to your desk and we can verify all this CSS is necessary.
OLD	NEW