Embedded Extension Options: Improve the overlay popup UI

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 177 matching lines @@
         fileAccess.querySelector('input').checked = extension.allowFileAccess;
         fileAccess.hidden = false;
       }
 
       // The 'Options' link.
       if (extension.enabled && extension.optionsUrl) {
         var options = node.querySelector('.options-link');
         options.addEventListener('click', function(e) {
           if (this.data_.enableEmbeddedExtensionOptions) {
             extensions.ExtensionOptionsOverlay.getInstance().
-                setExtensionAndShowOverlay(extension.id, extension.name);
+                setExtensionAndShowOverlay(extension.id,
+                                           extension.name,
+                                           extension.icon);
           } else {
             chrome.send('extensionSettingsOptions', [extension.id]);
           }
           e.preventDefault();
         }.bind(this));
         options.hidden = false;
       }
 
       // The 'Permissions' link.
       var permissions = node.querySelector('.permissions-link');
@@ skipping 205 matching lines @@
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });