Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 488273003: Only check for clean repos when not (--force or --reset). (Closed)

Created:
6 years, 4 months ago by iannucci
Modified:
6 years, 4 months ago
Reviewers:
agable, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Only check for clean repos when not (--force or --reset). This allows cache_dir to be enabled on bots when the individual repo path has changes (like android_tools, which has a bunch of generated, non-ignored .h files) R=agable@chromium.org, szager@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gclient_scm.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
6 years, 4 months ago (2014-08-20 22:52:35 UTC) #1
szager1
lgtm
6 years, 4 months ago (2014-08-20 23:04:39 UTC) #2
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 4 months ago (2014-08-20 23:05:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/488273003/1
6 years, 4 months ago (2014-08-20 23:06:29 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 23:08:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290943

Powered by Google App Engine
This is Rietveld 408576698