Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: mojo/services/public/interfaces/network/url_loader.mojom

Issue 488263002: Make struct members nullable so demo_launcher no longer crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/public/interfaces/input_events/input_events.mojom ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/interfaces/network/url_loader.mojom
diff --git a/mojo/services/public/interfaces/network/url_loader.mojom b/mojo/services/public/interfaces/network/url_loader.mojom
index da340c4cf0226b75c0dd095300385c5f2de7f8f5..a2cb346a41e72361755741ef3d8bbdc99eee2319 100644
--- a/mojo/services/public/interfaces/network/url_loader.mojom
+++ b/mojo/services/public/interfaces/network/url_loader.mojom
@@ -14,11 +14,11 @@ struct URLRequest {
string method = "GET";
// Additional HTTP request headers.
- string[] headers;
+ string[]? headers;
// The payload for the request body, represented as a concatenation of data
// streams. For HTTP requests, the method must be set to "POST" or "PUT".
- handle<data_pipe_consumer>[] body;
+ handle<data_pipe_consumer>[]? body;
// The number of bytes to be read from |body|. A Content-Length header of
// this value will be sent. Set to -1 if length is unknown, which will cause
@@ -43,7 +43,7 @@ struct URLRequest {
struct URLResponse {
// If the response resulted in a network level error, this field will be set.
- NetworkError error;
+ NetworkError? error;
// The response body stream. Read from this data pipe to receive the bytes of
// response body.
@@ -70,14 +70,14 @@ struct URLResponse {
// These fields are set to non-NULL if this response corresponds to a
// redirect. Call the |FollowRedirect| method on the URLLoader instance to
// follow this redirect.
- string redirect_method;
- string redirect_url;
+ string? redirect_method;
+ string? redirect_url;
};
struct URLLoaderStatus {
// If the loader has failed due to a network level error, this field will be
// set.
- NetworkError error;
+ NetworkError? error;
// Set to true if the URLLoader is still working. Set to false once an error
// is encountered or the response body is completely copied to the response
« no previous file with comments | « mojo/services/public/interfaces/input_events/input_events.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698