Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 488263002: Make struct members nullable so demo_launcher no longer crashes. (Closed)

Created:
6 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 4 months ago
CC:
yzshen1, chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make struct members nullable so demo_launcher no longer crashes. This change fixes a few mojom declarations that were causing the mojo_demo_launcher to crash when fetching a simple Apache "It works!" web page. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291029

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address CR comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 4 months ago (2014-08-20 20:09:07 UTC) #1
darin (slow to review)
LGTM, thanks!
6 years, 4 months ago (2014-08-20 20:26:48 UTC) #2
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 4 months ago (2014-08-20 20:32:58 UTC) #3
yzshen1
Thanks! LGTM One nit https://codereview.chromium.org/488263002/diff/1/mojo/services/public/interfaces/network/url_loader.mojom File mojo/services/public/interfaces/network/url_loader.mojom (right): https://codereview.chromium.org/488263002/diff/1/mojo/services/public/interfaces/network/url_loader.mojom#newcode79 mojo/services/public/interfaces/network/url_loader.mojom:79: // set. The comment sounds ...
6 years, 4 months ago (2014-08-20 20:34:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/488263002/1
6 years, 4 months ago (2014-08-20 20:34:17 UTC) #5
acolwell GONE FROM CHROMIUM
The CQ bit was unchecked by acolwell@chromium.org
6 years, 4 months ago (2014-08-20 20:36:30 UTC) #6
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/488263002/diff/1/mojo/services/public/interfaces/network/url_loader.mojom File mojo/services/public/interfaces/network/url_loader.mojom (right): https://codereview.chromium.org/488263002/diff/1/mojo/services/public/interfaces/network/url_loader.mojom#newcode79 mojo/services/public/interfaces/network/url_loader.mojom:79: // set. On 2014/08/20 20:34:15, yzshen1 wrote: > The ...
6 years, 4 months ago (2014-08-20 20:38:11 UTC) #7
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 4 months ago (2014-08-20 20:39:06 UTC) #8
acolwell GONE FROM CHROMIUM
6 years, 4 months ago (2014-08-20 20:39:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/488263002/20001
6 years, 4 months ago (2014-08-20 20:41:14 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 22:50:14 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 22:54:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55218) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/7994)
6 years, 4 months ago (2014-08-20 22:54:25 UTC) #13
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-21 04:16:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/488263002/20001
6 years, 4 months ago (2014-08-21 04:21:01 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 09:39:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291029

Powered by Google App Engine
This is Rietveld 408576698