Show additional warning about managed workflow.

Show additional warning about managed workflow.

Additional changes:
 * Use git.bat on Windows.
 * Collect insteadOf entries.
 * Catch one more ACL error.

R=iannucci@chromium.org
BUG=399054
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290955

[Vadim Sh., 2014-08-20 19:35:43]

ptal

[iannucci, 2014-08-20 20:26:28]

lgtm

https://codereview.chromium.org/488243002/diff/20001/tools/check_git_config.py
File tools/check_git_config.py (right):

https://codereview.chromium.org/488243002/diff/20001/tools/check_git_config.p...
tools/check_git_config.py:367: if current['url'] != good['url'] or
current['deps_file'] != good['deps_file']:
maybe just pop out managed from both and see if the remainder compares?

https://codereview.chromium.org/488243002/diff/20001/tools/check_git_config.p...
tools/check_git_config.py:382: print 'You are using deprecated managed gclient
mode.'
let's find the ML discussion where we announced that it was deprecated, and
include the date.

[Vadim Sh., 2014-08-20 21:10:34]

ptal

https://codereview.chromium.org/488243002/diff/20001/tools/check_git_config.py
File tools/check_git_config.py (right):

https://codereview.chromium.org/488243002/diff/20001/tools/check_git_config.p...
tools/check_git_config.py:367: if current['url'] != good['url'] or
current['deps_file'] != good['deps_file']:
On 2014/08/20 20:26:28, iannucci wrote:
> maybe just pop out managed from both and see if the remainder compares?

I don't want to pop anything, since these dicts later presented in 'print'.

https://codereview.chromium.org/488243002/diff/20001/tools/check_git_config.p...
tools/check_git_config.py:382: print 'You are using deprecated managed gclient
mode.'
On 2014/08/20 20:26:28, iannucci wrote:
> let's find the ML discussion where we announced that it was deprecated, and
> include the date.

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/n9N5N3JL2_U

8/22/13

[Vadim Sh., 2014-08-20 22:08:13]

Use git.bat. Collect insteadOf entries, bump version so the hook reruns (with
new git.bat).

[iannucci, 2014-08-20 22:12:59]

https://codereview.chromium.org/488243002/diff/60001/tools/check_git_config.py
File tools/check_git_config.py (right):

https://codereview.chromium.org/488243002/diff/60001/tools/check_git_config.p...
tools/check_git_config.py:404: print 'You are using managed gclient mode
deprecated on 8/22/13.'
You are using managed gclient mode with git, which was deprecated on 8/22/13
(link-to-google-groups-discussion).

https://codereview.chromium.org/488243002/diff/60001/tools/check_git_config.p...
tools/check_git_config.py:409: print
'http://www.chromium.org/developers/how-tos/get-the-code#Managed_mode'
Also mention that there is a large suite of tools to assist managing git
checkouts (for those who want help). The docs for them can be accessed by
running `man depot_tools` on *nix, and/or reading
{DEPOT_TOOLS}/man/html/depot_tools.html.

[Vadim Sh., 2014-08-20 23:46:13]

https://codereview.chromium.org/488243002/diff/60001/tools/check_git_config.py
File tools/check_git_config.py (right):

https://codereview.chromium.org/488243002/diff/60001/tools/check_git_config.p...
tools/check_git_config.py:404: print 'You are using managed gclient mode
deprecated on 8/22/13.'
On 2014/08/20 22:12:59, iannucci wrote:
> You are using managed gclient mode with git, which was deprecated on 8/22/13
> (link-to-google-groups-discussion).

Done.

https://codereview.chromium.org/488243002/diff/60001/tools/check_git_config.p...
tools/check_git_config.py:409: print
'http://www.chromium.org/developers/how-tos/get-the-code#Managed_mode'
On 2014/08/20 22:12:59, iannucci wrote:
> Also mention that there is a large suite of tools to assist managing git
> checkouts (for those who want help). The docs for them can be accessed by
> running `man depot_tools` on *nix, and/or reading
> {DEPOT_TOOLS}/man/html/depot_tools.html.

Done.

[iannucci, 2014-08-20 23:55:56]

lgtm

[Vadim Sh., 2014-08-20 23:57:41]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2014-08-21 00:00:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vadimsh@chromium.org/488243002/80001

[commit-bot: I haz the power, 2014-08-21 00:08:38]

Committed patchset #5 (80001) as 290955