Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 488213002: Add --properties for things like gitHash that describe the current nanobench run. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add --properties for things like gitHash that describe the current nanobench run. --key describes the type of run (describes the line on the chart), --properties describes the run itself (describes the dot on the chart). We'll pass --properties gitHash <git hash> build_number <build number> --key ... to nanobench from the bots. And... delete a whole lot of dead code. Example: nanobench --properties gitHash foo build_number 1234 --key bar baz { "build_number" : "1234", "gitHash" : "foo", "key" : { "bar" : "baz" }, "results" : { .... Friends with https://codereview.chromium.org/491943002 BUG=skia: Committed: https://skia.googlesource.com/skia/+/1915b62637bea20e1471a8a358b22e9e47a4a385

Patch Set 1 #

Patch Set 2 : styled, comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -315 lines) Patch
M bench/ResultsWriter.h View 1 5 chunks +29 lines, -207 lines 0 comments Download
D bench/ResultsWriter.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M bench/nanobench.cpp View 5 chunks +21 lines, -41 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/iOSShell.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/PictureResultsWriter.h View 4 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 4 months ago (2014-08-20 18:22:50 UTC) #1
jcgregorio
On 2014/08/20 18:22:50, mtklein wrote: LGTM Gotta love deleting that much code!
6 years, 4 months ago (2014-08-20 18:35:52 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-20 18:38:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/488213002/2
6 years, 4 months ago (2014-08-20 18:38:26 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 18:45:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (2) as 1915b62637bea20e1471a8a358b22e9e47a4a385

Powered by Google App Engine
This is Rietveld 408576698