Source/core/rendering/RenderBlock.cpp - Issue 488183003: Multi-column properties in a flexbox hide its content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 488183003: Multi-column properties in a flexbox hide its content (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/css3/flexbox/flexbox-hidden-by-multi-column-property.html ('K') | « LayoutTests/css3/flexbox/flexbox-hidden-by-multi-column-property-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index c600ee328d9aef57dc2b963d1bcc4a61b85e4bc2..619d96c552721eec3cba8c7afbea56c06a433617 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -3300,7 +3300,7 @@ bool RenderBlock::requiresColumns(int desiredColumnCount) const

return firstChild()

&& (desiredColumnCount != 1 || !style()->hasAutoColumnWidth() || isPaginated)

&& !firstChild()->isAnonymousColumnsBlock()

- && !firstChild()->isAnonymousColumnSpanBlock();

+ && !firstChild()->isAnonymousColumnSpanBlock() && !isFlexibleBoxIncludingDeprecated();

}

void RenderBlock::setDesiredColumnCountAndWidth(int count, LayoutUnit width)