Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 488173003: Add ui_unittests to GN build. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, dcheng
Project:
chromium
Visibility:
Public.

Description

Add ui_unittests to GN build. Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file. Reland of 291154 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291483

Patch Set 1 #

Patch Set 2 : iFix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -11 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/BUILD.gn View 1 1 chunk +177 lines, -0 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_unittests.gyp View 1 4 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
This is a reland from https://codereview.chromium.org/496473003/ Previous change is in patch set 1. It was ...
6 years, 4 months ago (2014-08-22 18:16:58 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-22 19:30:51 UTC) #2
brettw
6 years, 4 months ago (2014-08-22 19:51:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 291483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698