Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 488163003: Ensures Chrome only honors x-chrome-manage-accounts header on user initiated top frame requests. (Closed)

Created:
6 years, 4 months ago by guohui
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Ensures Chrome only honors x-chrome-manage-accounts header on user initiated top frame requests. BUG=394869 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/signin/signin_header_helper.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 4 months ago (2014-08-20 19:33:54 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-08-21 17:08:47 UTC) #2
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-21 17:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/488163003/1
6 years, 4 months ago (2014-08-21 17:18:41 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:58:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 291254

Powered by Google App Engine
This is Rietveld 408576698