Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 488163002: [CSSGridLayout] <embed> elements leaving stale pointers into grid (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-element-embed-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderGrid.cpp
diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp
index 2550717785c3938577fe2e03984e08f7e720f2bb..493648c28ae6fd1493c6c8ee750abacb5d87103c 100644
--- a/Source/core/rendering/RenderGrid.cpp
+++ b/Source/core/rendering/RenderGrid.cpp
@@ -206,6 +206,7 @@ void RenderGrid::addChild(RenderObject* newChild, RenderObject* beforeChild)
if (beforeChild && beforeChild->parent() != this) {
ASSERT(beforeChild->parent()->isAnonymous());
beforeChild = splitAnonymousBoxesAroundChild(beforeChild);
+ dirtyGrid();
}
RenderBlock::addChild(newChild, beforeChild);
« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-element-embed-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698