Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 488133005: Cast: Fix memory leak in cast_unittests (Closed)

Created:
6 years, 4 months ago by Alpha Left Google
Modified:
6 years, 3 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cast: Fix memory leak in cast_unittests Testing clock needs an owner. Put a scoped_ptr<> to where it was first created. BUG=400728 Committed: https://crrev.com/6618cd1694953a98e999f7b4d0b4db95717a17aa Cr-Commit-Position: refs/heads/master@{#292441}

Patch Set 1 #

Patch Set 2 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M media/cast/net/rtcp/rtcp_unittest.cc View 1 13 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Alpha Left Google
6 years, 4 months ago (2014-08-21 23:17:54 UTC) #1
hubbe
lgtm
6 years, 4 months ago (2014-08-22 16:35:49 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 4 months ago (2014-08-22 17:32:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/488133005/20001
6 years, 4 months ago (2014-08-22 17:33:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 18:27:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 18:30:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8642)
6 years, 4 months ago (2014-08-22 18:30:13 UTC) #7
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 3 months ago (2014-08-28 18:48:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/488133005/20001
6 years, 3 months ago (2014-08-28 18:50:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 27c31290f4c6cf3d6eabffafc6f1df21b2ba34c3
6 years, 3 months ago (2014-08-28 19:20:20 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6618cd1694953a98e999f7b4d0b4db95717a17aa
Cr-Commit-Position: refs/heads/master@{#292441}

Powered by Google App Engine
This is Rietveld 408576698