ozone: evdev: Add DOM3 code string to Ozone evdev key events.

ozone: evdev: Add DOM3 code string to Ozone evdev key events.

Have ui::KeycodeConverter::NativeKeycode use evdev codes when
compiled appropriately.

TEST=Manually tested on link_freon.
BUG=362698
Committed: https://crrev.com/11b8617a1b0c934d741aba34cb3c139a9fbee272
Cr-Commit-Position: refs/heads/master@{#292251}

[spang, 2014-08-20 19:23:36]

https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
File ui/events/ozone/evdev/key_event_converter_evdev.cc (right):

https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
ui/events/ozone/evdev/key_event_converter_evdev.cc:19: 
const int kXkbKeycodeOffset = 8;

Or choose your own name ;)

https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
ui/events/ozone/evdev/key_event_converter_evdev.cc:269:
KeycodeConverter::GetInstance()->NativeKeycodeToCode(key + 8),
kXkbKeycodeOffset

Who builds KeycodeConverter? Is it stateful?

[spang, 2014-08-20 19:26:56]

On 2014/08/20 19:23:36, spang wrote:
>
https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
> File ui/events/ozone/evdev/key_event_converter_evdev.cc (right):
> 
>
https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
> ui/events/ozone/evdev/key_event_converter_evdev.cc:19: 
> const int kXkbKeycodeOffset = 8;
> 
> Or choose your own name ;)
> 
>
https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
> ui/events/ozone/evdev/key_event_converter_evdev.cc:269:
> KeycodeConverter::GetInstance()->NativeKeycodeToCode(key + 8),
> kXkbKeycodeOffset
> 
> Who builds KeycodeConverter? Is it stateful?

Okay, it's a lazy singleton. Weird.

[spang, 2014-08-20 19:35:32]

lgtm

[kpschoedel, 2014-08-20 19:36:11]

https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
File ui/events/ozone/evdev/key_event_converter_evdev.cc (right):

https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
ui/events/ozone/evdev/key_event_converter_evdev.cc:19: 
On 2014/08/20 19:23:36, spang wrote:
> const int kXkbKeycodeOffset = 8;
> 
> Or choose your own name ;)

Done.

[kpschoedel, 2014-08-22 14:25:37]

+garykac@ for ui/events/keycodes/dom4/keycode_converter.cc

https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
File ui/events/ozone/evdev/key_event_converter_evdev.cc (right):

https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
ui/events/ozone/evdev/key_event_converter_evdev.cc:19: 
On 2014/08/20 19:36:10, kpschoedel wrote:
> On 2014/08/20 19:23:36, spang wrote:
> > const int kXkbKeycodeOffset = 8;

On reflection I think it's better to have NativeKeycodeToCode() actually accept
the true native code in this case (evdev).

[spang, 2014-08-22 16:46:04]

On 2014/08/22 14:25:37, kpschoedel wrote:
> +garykac@ for ui/events/keycodes/dom4/keycode_converter.cc
> 
>
https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
> File ui/events/ozone/evdev/key_event_converter_evdev.cc (right):
> 
>
https://codereview.chromium.org/488123004/diff/1/ui/events/ozone/evdev/key_ev...
> ui/events/ozone/evdev/key_event_converter_evdev.cc:19: 
> On 2014/08/20 19:36:10, kpschoedel wrote:
> > On 2014/08/20 19:23:36, spang wrote:
> > > const int kXkbKeycodeOffset = 8;
> 
> On reflection I think it's better to have NativeKeycodeToCode() actually
accept
> the true native code in this case (evdev).

You can choose at runtime between platforms based on evdev and platforms not
based on evdev. So having a decision about evdev usage in an ifdef can't be
correct in all case. It was more correct before ;).

[kpschoedel, 2014-08-26 21:35:05]

kpschoedel@chromium.org changed reviewers:
+ sadrul@chromium.org
- garykac@chromium.org

[kpschoedel, 2014-08-26 21:35:05]

+sadrul for ui/events/events.gyp

[kpschoedel, 2014-08-26 21:37:59]

Patchset #3 (id:100001) has been deleted

[kpschoedel, 2014-08-26 21:38:45]

kpschoedel@chromium.org changed reviewers:
- sadrul@chromium.org

[kpschoedel, 2014-08-26 21:38:45]

-sadrul@… removing the last patch set.

[kpschoedel, 2014-08-27 21:36:43]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-08-27 21:37:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/488123004/160001

[commit-bot: I haz the power, 2014-08-27 22:39:56]

Committed patchset #5 (id:160001) as 37834d76bc145a3ff501d96d14ca4192e38525f2

[commit-bot: I haz the power, 2014-09-10 02:55:03]

Patchset 5 (id:??) landed as
https://crrev.com/11b8617a1b0c934d741aba34cb3c139a9fbee272
Cr-Commit-Position: refs/heads/master@{#292251}