mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 488123003: Mojo cpp bindings: remove IsNonNullableValidationEnabled() check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 488123003: Mojo cpp bindings: remove IsNonNullableValidationEnabled() check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index 12e2dbba45b5128fd0bdaefd1eda4088fe1b640b..5ce9268e5f02abe14adde9915b57ea99b83b474a 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -17,8 +17,7 @@

{%- if kind|is_object_kind %}

{%- set wrapper_type = kind|cpp_wrapper_type %}

{%- if not kind|is_nullable_kind %}

- if (mojo::internal::IsNonNullableValidationEnabled() &&

- !object->{{name}}.offset) {

+ if (!object->{{name}}.offset) {

ReportValidationError(

mojo::internal::VALIDATION_ERROR_UNEXPECTED_NULL_POINTER);

return false;

@@ -42,8 +41,7 @@

}

{%- elif kind|is_any_handle_kind %}

{%- if not kind|is_nullable_kind %}

- if (mojo::internal::IsNonNullableValidationEnabled() &&

- object->{{name}}.value() == mojo::internal::kEncodedInvalidHandleValue) {

+ if (object->{{name}}.value() == mojo::internal::kEncodedInvalidHandleValue) {

ReportValidationError(

mojo::internal::VALIDATION_ERROR_UNEXPECTED_INVALID_HANDLE);

return false;