mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 488123003: Mojo cpp bindings: remove IsNonNullableValidationEnabled() check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 488123003: Mojo cpp bindings: remove IsNonNullableValidationEnabled() check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/lib/validation_errors.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index 2c8a0646bb06d490ada8f815f25e4d876147f01c..e1b82ebd8b0115d7656f47e67b9d76fdcecfffe3 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -60,8 +60,7 @@ params->{{param.name}}

{%- endif %}

{%- if not param.kind|is_nullable_kind %}

MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(

- mojo::internal::IsNonNullableValidationEnabled() &&

- !params->{{param.name}}.ptr,

+ !params->{{param.name}}.ptr,

mojo::internal::VALIDATION_ERROR_UNEXPECTED_NULL_POINTER);

{%- endif %}

{%- elif param.kind|is_any_handle_kind %}

@@ -74,8 +73,7 @@ params->{{param.name}}

{%- endif %}

{%- if not param.kind|is_nullable_kind %}

MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(

- mojo::internal::IsNonNullableValidationEnabled() &&

- !params->{{param.name}}.is_valid(),

+ !params->{{param.name}}.is_valid(),

mojo::internal::VALIDATION_ERROR_UNEXPECTED_INVALID_HANDLE);

{%- endif %}

{%- else %}