Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Issue 488123003: Mojo cpp bindings: remove IsNonNullableValidationEnabled() check (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
Reviewers:
hansmuller
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo cpp bindings: remove IsNonNullableValidationEnabled() check This check has already been changed to always return true in a previous CL. BUG=324170 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -32 lines) Patch
M mojo/public/cpp/bindings/lib/array_internal.h View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.h View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yzshen1
Hi, Hans. Would you please take a look? Thanks!
6 years, 4 months ago (2014-08-20 18:15:12 UTC) #1
hansmuller
On 2014/08/20 18:15:12, yzshen1 wrote: > Hi, Hans. > > Would you please take a ...
6 years, 4 months ago (2014-08-20 19:12:59 UTC) #2
yzshen1
On 2014/08/20 19:12:59, hansmuller wrote: > On 2014/08/20 18:15:12, yzshen1 wrote: > > Hi, Hans. ...
6 years, 4 months ago (2014-08-20 19:20:58 UTC) #3
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-20 19:21:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/488123003/1
6 years, 4 months ago (2014-08-20 19:24:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-20 20:24:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 22:08:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/3850)
6 years, 4 months ago (2014-08-20 22:08:44 UTC) #8
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-20 22:59:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/488123003/1
6 years, 4 months ago (2014-08-20 23:00:59 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 23:46:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 290951

Powered by Google App Engine
This is Rietveld 408576698