Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 488123002: Fix typo in LOG() statement. (Closed)

Created:
6 years, 4 months ago by simonb (inactive)
Modified:
6 years, 4 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix typo in LOG() statement. Replace packed_relocationss_offset by packed_relocations_offset. Fixes compile error from logged variable, invisible where CRAZY_DEBUG is zero (default). BUG=385553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291086

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/android_crazy_linker/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
simonb (inactive)
6 years, 4 months ago (2014-08-20 14:34:59 UTC) #1
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 4 months ago (2014-08-20 14:35:15 UTC) #2
rmcilroy
lgtm, thanks.
6 years, 4 months ago (2014-08-20 14:35:24 UTC) #3
rmcilroy
The CQ bit was unchecked by rmcilroy@chromium.org
6 years, 4 months ago (2014-08-20 14:35:31 UTC) #4
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 4 months ago (2014-08-20 14:35:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/488123002/1
6 years, 4 months ago (2014-08-20 14:36:27 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 15:51:52 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 15:53:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44179) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/7351) ios_rel_device ...
6 years, 4 months ago (2014-08-20 15:53:21 UTC) #9
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 4 months ago (2014-08-21 13:14:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/488123002/20001
6 years, 4 months ago (2014-08-21 13:14:52 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 16:22:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291086

Powered by Google App Engine
This is Rietveld 408576698