Have TabAndroid object implement the SearchTabHelperDelegate to provide the necessary functionality…

Have TabAndroid to implement the SearchTabHelperDelegate interface to provide the necessary functionality to SearchTabHelper.

This will allow us to turn off search term replacement (by updating the location bar displayed url) when the underlying page doesn't support embedded search.

Server side bug: b/17140979

BUG=none
TEST=none

Committed: https://crrev.com/0cd6622525e64c1558ed22b6e62fdf77a0838377
Cr-Commit-Position: refs/heads/master@{#291603}

[kmadhusu, 2014-08-22 19:57:20]

Please review.

Thanks.

[kmadhusu, 2014-08-22 23:50:12]

Moved the JNI function to Tab.java. PTAL.

Thanks.

[Yaron, 2014-08-22 23:55:10]

https://codereview.chromium.org/488093003/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/488093003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1005: protected
void updateUrlToPageUrl() {
actually this name doesn't make much sense by itself. Can you make this mirror
the native function (OnWebContentsInstantSupportDisabled)?

[kmadhusu, 2014-08-23 00:10:35]

https://codereview.chromium.org/488093003/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/488093003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1005: protected
void updateUrlToPageUrl() {
On 2014/08/22 23:55:10, Yaron wrote:
> actually this name doesn't make much sense by itself. Can you make this mirror
> the native function (OnWebContentsInstantSupportDisabled)?

Done.

[Yaron, 2014-08-23 00:14:21]

lgtm

https://codereview.chromium.org/488093003/diff/40001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/488093003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1005: protected
void OnWebContentsInstantSupportDisabled() {
nit: for java this should be named onWeb..

[kmadhusu, 2014-08-23 00:24:58]

https://codereview.chromium.org/488093003/diff/40001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/488093003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1005: protected
void OnWebContentsInstantSupportDisabled() {
On 2014/08/23 00:14:21, Yaron wrote:
> nit: for java this should be named onWeb..

Done.

[kmadhusu, 2014-08-23 00:28:18]

The CQ bit was checked by kmadhusu@chromium.org

[commit-bot: I haz the power, 2014-08-23 04:56:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/488093003/60001

[commit-bot: I haz the power, 2014-08-23 22:09:58]

Committed patchset #4 (60001) as ae406909e34b21b90a96ba2197497462a319942f

[commit-bot: I haz the power, 2014-09-10 02:31:52]

Patchset 4 (id:??) landed as
https://crrev.com/0cd6622525e64c1558ed22b6e62fdf77a0838377
Cr-Commit-Position: refs/heads/master@{#291603}