Issue 488083004: Remove SK_FONT_HOST_DOES_NOT_USE_FONTMGR and guarded code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 488083004: Remove SK_FONT_HOST_DOES_NOT_USE_FONTMGR and guarded code. (Closed)

Created:
6 years, 4 months ago by bungeman-skia

Modified:
6 years, 4 months ago

Reviewers:
djsollen, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove SK_FONT_HOST_DOES_NOT_USE_FONTMGR and guarded code. This define is no longer needed or set, so remove it from the code. Committed: https://skia.googlesource.com/skia/+/f47dfed7a2f6f3007934224313b23a39a04a466d

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -56 lines)			Patch
	M	src/core/SkFontHost.cpp	View		2 chunks	+0 lines, -17 lines	0 comments	Download
	M	src/ports/SkFontHost_fontconfig.cpp	View		1 chunk	+0 lines, -39 lines	0 comments	Download

Total messages: 6 (0 generated)

bungeman-skia

This define was introduced at the time just to keep the old Android code working. ...

6 years, 4 months ago (2014-08-20 14:27:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/488083004/1

6 years, 4 months ago (2014-08-20 14:49:14 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-20 15:01:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as f47dfed7a2f6f3007934224313b23a39a04a466d