chrome/test/data/password/done_and_separate_login_form.html - Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/done_and_separate_login_form.html

Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@branch_autofill_todo_20140813

Patch Set: Updated as per review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/test/data/password/separate_login_form_with_onload_submit_script.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script type="text/javascript">

	4 window.onload = function() {

	5 document.getElementById('to_separate').action = getLocationWithHttpSchemeSecur itySwapped();

	6 }

	7

	8 function getLocationWithHttpSchemeSecuritySwapped() {

	9 var protocol = ("http:" == window.location.protocol) ? "https://" : "http://";

	10 var url = protocol + window.location.host + window.location.pathname;

	11 return url;

	12 }

	13 </script>

	14 </head>

	15 <body>

	16 Navigation complete. Below is the different login form pushed by server but with same action URL.

	17 The URL schem may or may not be same. Moreover, browser shall not promp user to save incorrect password.

	18 <form method="POST" id="to_separate">

	19 <input type="text" id="username_separate" name="username_separate">

	20 <input type="password" id="password_separate" name="password_separate">

	21 <input type="submit" id="submit_separate" name="submit_separate">

	22 </form>

	23 </body>

	24 </html>

OLD	NEW