chrome/test/data/password/separate_login_form_with_onload_submit_script.html - Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/separate_login_form_with_onload_submit_script.html

Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@branch_autofill_todo_20140813

Patch Set: Incorporated review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/test/data/password/done_and_separate_login_form.html ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script type="text/javascript">

	4 // This testcase is having provision to submit form on completion of page load i tself.
	vabr (Chromium) 2014/09/01 08:39:39 optional nit: I think you can drop this comment, b optional nit: I think you can drop this comment, because the reason for using the onload script is described in the C++ callsite. If you do want to keep the comment here, then please consider rephrasing it in a simpler way, and also keep the lines length to 80 lines (to be consistent with the surrounding code). Pritam Nikam 2014/09/01 10:53:54 Done. Show quoted text On 2014/09/01 08:39:39, vabr (Chromium) wrote: > optional nit: I think you can drop this comment, because the reason for using > the onload script is described in the C++ callsite. If you do want to keep the > comment here, then please consider rephrasing it in a simpler way, and also keep > the lines length to 80 lines (to be consistent with the surrounding code). Done.
	5 // It has been added to overcome the problem as for HTTPS test servers content:: ExecuteScript()

	6 // API is failing to inject script on the fly.

	7 window.onload = function() {

	8 document.getElementById('username_separate').value = "user";

	9 document.getElementById('password_separate').value = "password";

	10 document.getElementById('submit_separate').click();

	11 }

	12 </script>

	13 <head>

	14 <body>

	15 <form method="POST" action="/password/done_and_separate_login_form.html" id="to_ separate">

	16 <input type="text" id="username_separate" name="username_separate">

	17 <input type="password" id="password_separate" name="password_separate">

	18 <input type="submit" id="submit_separate" name="submit_separate">

	19 </form>

	20 </body>

	21 </html>

OLD	NEW