Issue 488073002: Further reduce LookupResult usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 488073002: Further reduce LookupResult usage (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Yang, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Further reduce LookupResult usage BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23245

Patch Set 3 : More consistency #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -33 lines)			Patch
M	src/bootstrapper.cc	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	src/hydrogen.cc	View		2 chunks	+11 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+2 lines, -17 lines	0 comments	Download
M	src/ic.cc	View	1 2	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with question. https://codereview.chromium.org/488073002/diff/20001/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/488073002/diff/20001/src/ic.cc#newcode283 src/ic.cc:283: if (!it.HasProperty()) return false; More a ...

6 years, 4 months ago (2014-08-20 14:53:17 UTC) #2

Toon Verwaest

https://codereview.chromium.org/488073002/diff/20001/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/488073002/diff/20001/src/ic.cc#newcode283 src/ic.cc:283: if (!it.HasProperty()) return false; On 2014/08/20 14:53:17, Yang wrote: ...

6 years, 4 months ago (2014-08-20 15:04:33 UTC) #3

Toon Verwaest

6 years, 4 months ago (2014-08-20 15:08:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as 23245 (presubmit successful).

Expand Messages | Collapse Messages

Issue 488073002: Further reduce LookupResult usage (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : More consistency #

Messages