Issue 488053002: EventSender::KeyDown(): add "escape" and "backspace" key names.

Issue 488053002: EventSender::KeyDown(): add "escape" and "backspace" key names. (Closed)

Created:
6 years, 4 months ago by sof

Modified:
6 years, 4 months ago

Reviewers:
tkent, tfarina

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jbroman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

EventSender::KeyDown(): add "escape" and "backspace" key names. ..as their ASCII codes are used in various layout tests. Mapped to VKEY_ESCAPE and VKEY_BACK, respectively. R=tkent@chromium.org BUG=392517 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291110

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	content/shell/renderer/test_runner/event_sender.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

sof

Please take a look. A follow-up Blink CL will use these in various layout tests.

6 years, 4 months ago (2014-08-20 08:37:04 UTC) #1

jbroman

On 2014/08/20 08:37:04, sof wrote: > Please take a look. > > A follow-up Blink ...

6 years, 4 months ago (2014-08-20 19:49:46 UTC) #2

sof

jbroman@: thanks though, added you as you're "git blame"d for large chunks of the method ...

6 years, 4 months ago (2014-08-21 08:49:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/488053002/1

6 years, 4 months ago (2014-08-21 11:15:29 UTC) #6

Message was sent while issue was closed.

lgtm