Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 488043002: [turbofan] Add support for ChangeTaggedToUint32 in ChangeLowering. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for ChangeTaggedToUint32 in ChangeLowering. Also refactor some common code in ChangeLowering. TEST=cctest,compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -45 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/change-lowering.cc View 5 chunks +48 lines, -41 lines 0 comments Download
M test/compiler-unittests/change-lowering-unittest.cc View 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-20 06:07:36 UTC) #1
Jarin
lgtm
6 years, 4 months ago (2014-08-20 08:12:17 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-20 08:13:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698