Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: Source/core/dom/NodeIterator.h

Issue 48803004: Have Document::nodeWillBeRemoved() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/NodeIterator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2000 Frederik Holljen (frederik.holljen@hig.no) 3 * Copyright (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
4 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 4 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
5 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 ~NodeIterator(); 44 ~NodeIterator();
45 45
46 PassRefPtr<Node> nextNode(ScriptState*, ExceptionState&); 46 PassRefPtr<Node> nextNode(ScriptState*, ExceptionState&);
47 PassRefPtr<Node> previousNode(ScriptState*, ExceptionState&); 47 PassRefPtr<Node> previousNode(ScriptState*, ExceptionState&);
48 void detach(); 48 void detach();
49 49
50 Node* referenceNode() const { return m_referenceNode.node.get(); } 50 Node* referenceNode() const { return m_referenceNode.node.get(); }
51 bool pointerBeforeReferenceNode() const { return m_referenceNode.isPointerBe foreNode; } 51 bool pointerBeforeReferenceNode() const { return m_referenceNode.isPointerBe foreNode; }
52 52
53 // This function is called before any node is removed from the document tree . 53 // This function is called before any node is removed from the document tree .
54 void nodeWillBeRemoved(Node*); 54 void nodeWillBeRemoved(Node&);
55 55
56 private: 56 private:
57 NodeIterator(PassRefPtr<Node>, unsigned whatToShow, PassRefPtr<NodeFilter>); 57 NodeIterator(PassRefPtr<Node>, unsigned whatToShow, PassRefPtr<NodeFilter>);
58 58
59 struct NodePointer { 59 struct NodePointer {
60 RefPtr<Node> node; 60 RefPtr<Node> node;
61 bool isPointerBeforeNode; 61 bool isPointerBeforeNode;
62 NodePointer(); 62 NodePointer();
63 NodePointer(PassRefPtr<Node>, bool); 63 NodePointer(PassRefPtr<Node>, bool);
64 void clear(); 64 void clear();
65 bool moveToNext(Node* root); 65 bool moveToNext(Node* root);
66 bool moveToPrevious(Node* root); 66 bool moveToPrevious(Node* root);
67 }; 67 };
68 68
69 void updateForNodeRemoval(Node* nodeToBeRemoved, NodePointer&) const; 69 void updateForNodeRemoval(Node& nodeToBeRemoved, NodePointer&) const;
70 70
71 NodePointer m_referenceNode; 71 NodePointer m_referenceNode;
72 NodePointer m_candidateNode; 72 NodePointer m_candidateNode;
73 bool m_detached; 73 bool m_detached;
74 }; 74 };
75 75
76 } // namespace WebCore 76 } // namespace WebCore
77 77
78 #endif // NodeIterator_h 78 #endif // NodeIterator_h
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/NodeIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698