Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: ipc/ipc_test_base.h

Issue 488003003: Add ChannelProxy benchmark to ipc_perftests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Landing. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_perftests.cc ('k') | ipc/ipc_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_test_base.h
diff --git a/ipc/ipc_test_base.h b/ipc/ipc_test_base.h
index ce3328ad1058d6544f88779e42bda308735fe645..acad47764368c9a0ac4988076ac2ca647afdad30 100644
--- a/ipc/ipc_test_base.h
+++ b/ipc/ipc_test_base.h
@@ -16,7 +16,7 @@
#include "ipc/ipc_multiprocess_test.h"
namespace base {
-class MessageLoopForIO;
+class MessageLoop;
}
// A test fixture for multiprocess IPC tests. Such tests include a "client" side
@@ -86,11 +86,21 @@ class IPCTestBase : public base::MultiProcessTest {
IPC::ChannelProxy* channel_proxy() { return channel_proxy_.get(); }
const base::ProcessHandle& client_process() const { return client_process_; }
- scoped_refptr<base::TaskRunner> io_thread_task_runner();
+ scoped_refptr<base::TaskRunner> task_runner();
+
+ // Some tests creates separate thread for IO message loop and Run
+ // non-IO message loop on the main thread. As IPCTestBase creates IO
+ // message loop by default, such tests might want to replace it with
+ // non-IO one using set_message_loop().
+ //
+ // The replacement should be done at the beginning of the test.
+ // You should be careful not to replace "live" message loop that has
+ // started running.
+ void set_message_loop(scoped_ptr<base::MessageLoop> loop);
private:
std::string test_client_name_;
- scoped_ptr<base::MessageLoopForIO> message_loop_;
+ scoped_ptr<base::MessageLoop> message_loop_;
scoped_ptr<IPC::Channel> channel_;
scoped_ptr<IPC::ChannelProxy> channel_proxy_;
« no previous file with comments | « ipc/ipc_perftests.cc ('k') | ipc/ipc_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698