Include content/content_shell_and_tests.gyp:* for all platforms.

Include content/content_shell_and_tests.gyp:* for all platforms.

The content_unittests target used to be pulled in by content.gyp:*
but after a refactoring it is necessary to explicitly include it via
content/content_shell_and_tests.gyp:*

BUG=None
R=jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231394

[jochen (gone - plz use gerrit), 2013-10-28 13:52:51]

https://codereview.chromium.org/48793002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/48793002/diff/1/build/all.gyp#newcode75
build/all.gyp:75: '../content/content_shell_and_tests.gyp:content_unittests',
why not just *

[blundell, 2013-10-28 13:59:57]

https://codereview.chromium.org/48793002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/48793002/diff/1/build/all.gyp#newcode75
build/all.gyp:75: '../content/content_shell_and_tests.gyp:content_unittests',
Is there a reason why the top section shouldn't just have this line actually
(with nothing else about content_shell_and_tests.gyp in either the iOS or !iOS
sections)? It's not clear to me and Lane why the !iOS section specifies targets
from content_shell_and_tests.gyp individually.

On 2013/10/28 13:52:51, jochen wrote:
> why not just *

[jochen (gone - plz use gerrit), 2013-10-28 14:06:15]

https://codereview.chromium.org/48793002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/48793002/diff/1/build/all.gyp#newcode75
build/all.gyp:75: '../content/content_shell_and_tests.gyp:content_unittests',
On 2013/10/28 13:59:57, blundell wrote:
> Is there a reason why the top section shouldn't just have this line actually
> (with nothing else about content_shell_and_tests.gyp in either the iOS or !iOS
> sections)? It's not clear to me and Lane why the !iOS section specifies
targets
> from content_shell_and_tests.gyp individually.
> 
> On 2013/10/28 13:52:51, jochen wrote:
> > why not just *
> 

Good point.

We should probably add this line right next to the content.gyp:* line

[lliabraa, 2013-10-28 14:12:03]

https://codereview.chromium.org/48793002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/48793002/diff/1/build/all.gyp#newcode75
build/all.gyp:75: '../content/content_shell_and_tests.gyp:content_unittests',
On 2013/10/28 14:06:16, jochen wrote:
> On 2013/10/28 13:59:57, blundell wrote:
> > Is there a reason why the top section shouldn't just have this line actually
> > (with nothing else about content_shell_and_tests.gyp in either the iOS or
!iOS
> > sections)? It's not clear to me and Lane why the !iOS section specifies
> targets
> > from content_shell_and_tests.gyp individually.
> > 
> > On 2013/10/28 13:52:51, jochen wrote:
> > > why not just *
> > 
> 
> Good point.
> 
> We should probably add this line right next to the content.gyp:* line

Done.

[jochen (gone - plz use gerrit), 2013-10-28 14:13:29]

lgtm

[blundell, 2013-10-28 14:15:48]

You should update the CL description to better indicate the change that it's
making now.

[lliabraa, 2013-10-28 14:18:16]

On 2013/10/28 14:15:48, blundell wrote:
> You should update the CL description to better indicate the change that it's
> making now.

Done

[commit-bot: I haz the power, 2013-10-28 14:18:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/48793002/80002

[commit-bot: I haz the power, 2013-10-28 14:53:47]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[jochen (gone - plz use gerrit), 2013-10-28 14:56:12]

On 2013/10/28 14:53:47, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on linux_chromeos_clang.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

oh noes... seems like some unit tests don't even compile anymore :-/

we need to fix this ASAP

[commit-bot: I haz the power, 2013-10-28 15:27:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/48793002/80002

[commit-bot: I haz the power, 2013-10-28 15:52:52]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-28 20:03:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/48793002/80002

[jochen (gone - plz use gerrit), 2013-10-28 20:06:50]

Committed patchset #2 manually as r231394.