Issue 487913005: ARM64: Fix SHR logic error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 487913005: ARM64: Fix SHR logic error. (Closed)

Created:
6 years, 4 months ago by jbramley

Modified:
6 years, 4 months ago

Reviewers:
ulan, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

ARM64: Fix SHR logic error. The `right == 0` checks only worked for `0 <= right < 32`. This patch replaces the checks with simple tests for negative results. The attached test can detect this error, but the test relies on a broken flag (--noopt-safe-uint32-operations), so it is skipped for now. See issue 3487 for details. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23243

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -20 lines)			Patch
M	src/arm64/full-codegen-arm64.cc	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	2 chunks	+10 lines, -12 lines	0 comments	Download
A	test/mjsunit/compiler/shift-shr.js	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jbramley

If there's a better way to exercise this code without relying on --noopt-safe-uint32-operations, please let ...

6 years, 4 months ago (2014-08-20 14:20:58 UTC) #1

jbramley

6 years, 4 months ago (2014-08-20 14:58:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23243 (presubmit successful).

Expand Messages | Collapse Messages