Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 487863002: Ensure npapi plugin is loaded before clicking on it (Closed)

Created:
6 years, 4 months ago by Sami
Modified:
6 years, 4 months ago
Reviewers:
eseidel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Ensure npapi plugin is loaded before clicking on it PluginTest.SelfDeletePluginInvokeInSynchronousMouseUp loads a page with a plugin and then simulates a mouse click on the plugin. Because the page load event can fire before the plugin has actually finished loading, the test can fail when the mouse event ends up getting sent too soon. This patch improves the test by ensuring the plugin has been loaded. As <embed> does not support a generic onload listener (each plugin needs to implement one separately), we instead set a dummy property on the object, which, as a side effect, forces the plugin to load synchronously. BUG=391005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/test/data/npapi/execute_script_delete_in_mouse_up.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sami
6 years, 4 months ago (2014-08-19 17:07:17 UTC) #1
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-19 18:13:19 UTC) #2
eseidel
lgtm
6 years, 4 months ago (2014-08-19 18:13:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/487863002/1
6 years, 4 months ago (2014-08-19 18:14:13 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 19:55:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290637

Powered by Google App Engine
This is Rietveld 408576698