gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json - Issue 487853004: rebaseline_server: allow users to generate SKP diff patches on a shared instance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json

Issue 487853004: rebaseline_server: allow users to generate SKP diff patches on a shared instance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add TODOs for Stephan Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json ('k') | gm/rebaseline_server/writable_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json

diff --git a/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json b/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json

index ada58a3bd1dceb3419edef4e30a806f06e67ca3a..5ee60925ab7b80641935578308ae0ed951121add 100644

--- a/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json

+++ b/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json

@@ -128,7 +128,7 @@

"renderModeB"

"header": {

- "dataHash": "-1510211866509185075",

+ "dataHash": "-5707186260478709107",

"isEditable": false,

"isExported": true,

"schemaVersion": 5,

@@ -160,7 +160,8 @@

"imageAUrl": "changed_skp/bitmap-64bitMD5_3101044995537104462.png",

"imageBUrl": "changed_skp/bitmap-64bitMD5_13623922271964399662.png",

- "isDifferent": true

+ "isDifferent": true,

+ "sourceJsonFile": "./summary.json"

{

"extraColumns": {

@@ -175,7 +176,8 @@

"imageAUrl": null,

"imageBUrl": "only-in-after_skp/bitmap-64bitMD5_2320185040577047131.png",

- "isDifferent": true

+ "isDifferent": true,

+ "sourceJsonFile": "./summary.json"

{

"extraColumns": {

@@ -190,7 +192,8 @@

"imageAUrl": "only-in-before_skp/bitmap-64bitMD5_2320185040577047131.png",

"imageBUrl": null,

- "isDifferent": true

+ "isDifferent": true,

+ "sourceJsonFile": "./summary.json"

{

"extraColumns": {

@@ -205,7 +208,8 @@

"imageAUrl": "unchanged_skp/bitmap-64bitMD5_3322248763049618493.png",

"imageBUrl": "unchanged_skp/bitmap-64bitMD5_3322248763049618493.png",

- "isDifferent": false

+ "isDifferent": false,

+ "sourceJsonFile": "./summary.json"

}

"imageSets": {