gm/rebaseline_server/static/constants.js - Issue 487853004: rebaseline_server: allow users to generate SKP diff patches on a shared instance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/static/constants.js

Issue 487853004: rebaseline_server: allow users to generate SKP diff patches on a shared instance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add TODOs for Stephan Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/static/constants.js

diff --git a/gm/rebaseline_server/static/constants.js b/gm/rebaseline_server/static/constants.js

index aa4b63aa9ee484363af800f6e227bd938aa04075..a9601ece719dc95c4074662398a13de4ef7fc142 100644

--- a/gm/rebaseline_server/static/constants.js

+++ b/gm/rebaseline_server/static/constants.js

@@ -31,6 +31,7 @@ module.constant('constants', (function() {

KEY__IMAGEPAIRS__IMAGE_A_URL: 'imageAUrl',

KEY__IMAGEPAIRS__IMAGE_B_URL: 'imageBUrl',

KEY__IMAGEPAIRS__IS_DIFFERENT: 'isDifferent',

+ KEY__IMAGEPAIRS__SOURCE_JSON_FILE: 'sourceJsonFile',

// NOTE: Keep these in sync with ../imagepairset.py

KEY__ROOT__EXTRACOLUMNHEADERS: 'extraColumnHeaders',

@@ -83,6 +84,9 @@ module.constant('constants', (function() {

KEY__EDITS__MODIFICATIONS: 'modifications',

KEY__EDITS__OLD_RESULTS_HASH: 'oldResultsHash',

KEY__EDITS__OLD_RESULTS_TYPE: 'oldResultsType',

+ KEY__LIVE_EDITS__MODIFICATIONS: 'modifications',

+ KEY__LIVE_EDITS__SET_A_DESCRIPTIONS: 'setA',

+ KEY__LIVE_EDITS__SET_B_DESCRIPTIONS: 'setB',

// These are just used on the client side, no need to sync with server code.

KEY__IMAGEPAIRS__ROWSPAN: 'rowspan',

« no previous file with comments | « gm/rebaseline_server/server.py ('k') | gm/rebaseline_server/static/live-loader.js » ('j') | no next file with comments »