Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: gm/rebaseline_server/results.py

Issue 487853004: rebaseline_server: allow users to generate SKP diff patches on a shared instance (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add TODOs for Stephan Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/imagepair.py ('k') | gm/rebaseline_server/server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/results.py
diff --git a/gm/rebaseline_server/results.py b/gm/rebaseline_server/results.py
index 11a7d6ecfdd7e9aa35a3e4d35185e207f7abcda0..b0027d22af3d19fd751217b067a0aa010cb2e784 100755
--- a/gm/rebaseline_server/results.py
+++ b/gm/rebaseline_server/results.py
@@ -213,7 +213,7 @@ class BaseComparisons(object):
Raises:
IOError if root does not refer to an existing directory
"""
- # I considered making this call _read_dicts_from_root(), but I decided
+ # I considered making this call read_dicts_from_root(), but I decided
# it was better to prune out the ignored builders within the os.walk().
if not os.path.isdir(root):
raise IOError('no directory found at path %s' % root)
@@ -227,9 +227,13 @@ class BaseComparisons(object):
meta_dict[builder] = gm_json.LoadFromFile(full_path)
return meta_dict
- def _read_dicts_from_root(self, root, pattern='*.json'):
+ @staticmethod
+ def read_dicts_from_root(root, pattern='*.json'):
"""Read all JSON dictionaries within a directory tree.
+ TODO(stephana): Factor this out into a utility module, as a standalone
+ function (not part of a class).
+
Args:
root: path to root of directory tree
pattern: which files to read within root (fnmatch-style pattern)
« no previous file with comments | « gm/rebaseline_server/imagepair.py ('k') | gm/rebaseline_server/server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698