ExtensionDelegate to abstract extension implementation

athena/extensions/public/extension_delegate.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ATHENA_EXTENSIONS_PUBLIC_EXTENSION_DELEGATE_H_
+#define ATHENA_EXTENSIONS_PUBLIC_EXTENSION_DELEGATE_H_
+
+#include <string>
+
+#include "athena/athena_export.h"
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+class ExtensionSet;
+}
+
+namespace athena {
+
+// A delegate interface to extension implentation.
+class ATHENA_EXPORT ExtensionDelegate {

[Yoyo Zhou, 2014/08/20 20:37:28]

nit: We would generally call this ExtensionsDelegate. (Extensions refers to the
system at large.)

[oshima, 2014/08/20 21:39:21]

Done.

+ public:
+  static ExtensionDelegate* Get(content::BrowserContext* context);
+  static void Shutdown();

[Yoyo Zhou, 2014/08/20 20:37:28]

Document when this gets called.

+
+  // Initializes the extension delegate for app shell environment.
+  static void InitExtensionDelegateForShell(content::BrowserContext* context);
+
+  ExtensionDelegate();
+  virtual ~ExtensionDelegate();
+
+  virtual content::BrowserContext* GetBrowserContext() const = 0;
+
+  // Returns the set of extensions that are currently installed.
+  virtual extensions::ExtensionSet* GetExtensionSet() = 0;

[Yoyo Zhou, 2014/08/20 20:37:27]

I'd prefer something like GetInstalledExtensions.

[oshima, 2014/08/20 21:39:21]

Done.

+
+  // Luanch an applicatino specified by |app_id|.

[Yoyo Zhou, 2014/08/20 20:37:27]

typo: Launch,  application

[oshima, 2014/08/20 21:39:21]

Done.

+  virtual void Launch(const std::string& app_id) = 0;

[Yoyo Zhou, 2014/08/20 20:37:28]

LaunchApp would be clearer.

[oshima, 2014/08/20 21:39:21]

Done.

+};
+
+}  // namespace athena
+
+#endif  // ATHENA_EXTENSIONS_PUBLIC_EXTENSION_DELEGATE_H_
+