pkg/polymer/test/build/linter_test.dart - Issue 487793002: html escape log messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/test/build/linter_test.dart

Issue 487793002: html escape log messages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: use const constructor for HtmlEscape Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/polymer/test/build/linter_test.dart

diff --git a/pkg/polymer/test/build/linter_test.dart b/pkg/polymer/test/build/linter_test.dart

index a834f9e546801ceca2dcdb0ee65bdc87f576f129..4ec76776b0e8942253f877acd08fcb6ab1abeb5f 100644

--- a/pkg/polymer/test/build/linter_test.dart

+++ b/pkg/polymer/test/build/linter_test.dart

@@ -664,11 +664,12 @@ void main() {

'a|web/test.html._buildLogs.1':

'[{'

'"level":"Warning",'

- '"message":${JSON.encode(usePolymerHtmlMessage(0))},'

+ '"message":${JSON.encode(const HtmlEscape().convert(

+ usePolymerHtmlMessage(0)))},'

'"span":{'

'"location":"web/test.html:2:1",'

'"text":'

- '"${new HtmlEscape().convert('<polymer-element name="x-a">')}"'

+ '"${const HtmlEscape().convert('<polymer-element name="x-a">')}"'

'}'

'}]',

}, [

« no previous file with comments | « pkg/polymer/test/build/import_inliner_test.dart ('k') | no next file » | no next file with comments »