Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: pkg/polymer/test/build/import_inliner_test.dart

Issue 487793002: html escape log messages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: use const constructor for HtmlEscape Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/build/wrapped_logger.dart ('k') | pkg/polymer/test/build/linter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/import_inliner_test.dart
diff --git a/pkg/polymer/test/build/import_inliner_test.dart b/pkg/polymer/test/build/import_inliner_test.dart
index edbaa0ea6f3a50e2f6f5280a442b03eb1e2d25ab..c25958a4b2c2483208a3d72a0b7f721081239866 100644
--- a/pkg/polymer/test/build/import_inliner_test.dart
+++ b/pkg/polymer/test/build/import_inliner_test.dart
@@ -682,12 +682,13 @@ void importTests() {
'a|web/test.html._buildLogs.1':
'[{'
'"level":"Error",'
- '"message":"Failed to inline html import: '
- 'Could not find asset a|web/foo.html.",'
+ '"message":"${const HtmlEscape().convert(
+ 'Failed to inline html import: '
+ 'Could not find asset a|web/foo.html.')}",'
'"assetId":{"package":"a","path":"web/foo.html"},'
'"span":{'
'"location":"web/test.html:1:28",'
- '"text":"${new HtmlEscape().convert(
+ '"text":"${const HtmlEscape().convert(
'<link rel="import" href="foo.html">')}"'
'}'
'}]',
@@ -1103,4 +1104,4 @@ void entryPointTests() {
'<script rel="import" href="../../packages/b/bar/bar.js"></script>'
'</body></html>',
});
-}
+}
« no previous file with comments | « pkg/polymer/lib/src/build/wrapped_logger.dart ('k') | pkg/polymer/test/build/linter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698