Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 487753003: Trace scavenger throughput. (Closed)

Created:
6 years, 4 months ago by ulan
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M src/heap/gc-tracer.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.cc View 3 chunks +20 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL
6 years, 4 months ago (2014-08-19 10:09:13 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/487753003/diff/20001/src/heap/gc-tracer.cc File src/heap/gc-tracer.cc (right): https://codereview.chromium.org/487753003/diff/20001/src/heap/gc-tracer.cc#newcode107 src/heap/gc-tracer.cc:107: heap_->new_space()->top() - heap_->new_space()->bottom(); The question here is: What is ...
6 years, 4 months ago (2014-08-19 11:52:59 UTC) #2
Hannes Payer (out of office)
As discussed offline, you are already accounting for both kinds of objects in the new ...
6 years, 4 months ago (2014-08-19 11:58:57 UTC) #3
ulan
6 years, 4 months ago (2014-08-19 12:08:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698