Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 487533006: app_shell: Allow window to load a normal URL (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

app_shell: Allow window to load a normal URL For testing purposes, allow shell.createWindow() to load a non-extension URL. BUG=none TEST=none Committed: https://crrev.com/0692b620049f9ef8fa1ee9f0cac271de1bdfdc77 Cr-Commit-Position: refs/heads/master@{#291736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M extensions/shell/browser/api/shell/shell_api.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Cook
jamescook@chromium.org changed reviewers: + derat@chromium.org
6 years, 4 months ago (2014-08-25 17:56:04 UTC) #1
James Cook
Dan, PTAL. I need to do something like this for testing. Eventually <webview> will replace ...
6 years, 4 months ago (2014-08-25 17:56:04 UTC) #2
Daniel Erat
lgtm this seems fine to me.
6 years, 4 months ago (2014-08-25 18:21:08 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-25 18:22:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/487533006/1
6 years, 4 months ago (2014-08-25 18:23:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as c34009e6a091cd1b2b62772ddec3a783ea48d55f
6 years, 4 months ago (2014-08-25 19:18:43 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:36:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0692b620049f9ef8fa1ee9f0cac271de1bdfdc77
Cr-Commit-Position: refs/heads/master@{#291736}

Powered by Google App Engine
This is Rietveld 408576698