Add support for references in different paths in apis

tools/json_schema_compiler/model.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os.path
 
 from json_parse import OrderedDict
 from memoize import memoize
 
 
 class ParseException(Exception):
   """Thrown when data in the model is invalid.
   """
   def __init__(self, parent, message):
     hierarchy = _GetModelHierarchy(parent)
     hierarchy.append(message)
     Exception.__init__(
         self, 'Model parse exception at:\n' + '\n'.join(hierarchy))
 
 
 class Model(object):
   """Model of all namespaces that comprise an API.
 
   Properties:
   - |namespaces| a map of a namespace name to its model.Namespace
   """
   def __init__(self):
     self.namespaces = {}
 
-  def AddNamespace(self, json, source_file, include_compiler_options=False):
+  def AddNamespace(self,
+                   json,
+                   source_file,
+                   cpp_namespace_pattern,

[not at google - send to devlin, 2014/08/25 22:22:47]

There's a reason a lot of these namespace-level properties aren't passed into
Namespace - it's supposed to be language agnostic. Pure model. Compiler specific
options should go in "compiler_options" but that's supposed to be configured at
the schema level, a literal replacement of the "compiler_options" schema
argument.

How about:

- add an optional "environment" variable to this which you can start bundling
those namespace-level options into. Ideally it'd even be typed, like,

class CppNamespaceEnvironment(object):
  def __init__(self, namespace_pattern):
    self.namespace_pattern = namespace_pattern

...

class Model(object):
  def AddNamespace(self, json, source_file,
                   include_compiler_options=False,
                   environment=None)
  ...

...

model.AddNamespace(
    json,
    source_file,
    environment=CppNamespaceEnvironment('foo::bar::baz'))

...

then access like "namespace.environment.namespace_pattern".

[lfg, 2014/08/26 16:15:22]

I thought this didn't feel right when I had to fix some of the tests and the
cpp_namespace_pattern didn't make sense.

Fixed with your suggestion.

+                   include_compiler_options=False):
     """Add a namespace's json to the model and returns the namespace.
     """
     namespace = Namespace(json,
                           source_file,
+                          cpp_namespace_pattern,
                           include_compiler_options=include_compiler_options)
     self.namespaces[namespace.name] = namespace
     return namespace
 
 
 def CreateFeature(name, model):
   if isinstance(model, dict):
     return SimpleFeature(name, model)
   return ComplexFeature(name, [SimpleFeature(name, child) for child in model])
 
@@ skipping 43 matching lines @@
   - |source_file_filename| the filename component of |source_file|
   - |platforms| if not None, the list of platforms that the namespace is
                 available to
   - |types| a map of type names to their model.Type
   - |functions| a map of function names to their model.Function
   - |events| a map of event names to their model.Function
   - |properties| a map of property names to their model.Property
   - |compiler_options| the compiler_options dict, only not empty if
                        |include_compiler_options| is True
   """
-  def __init__(self, json, source_file, include_compiler_options=False):
+  def __init__(self,
+               json,
+               source_file,
+               cpp_namespace_pattern='',
+               include_compiler_options=False):
     self.name = json['namespace']
     if 'description' not in json:
       # TODO(kalman): Go back to throwing an error here.
       print('%s must have a "description" field. This will appear '
                        'on the API summary page.' % self.name)
       json['description'] = ''
+    self.cpp_namespace_pattern = cpp_namespace_pattern
     self.description = json['description']
     self.deprecated = json.get('deprecated', None)
     self.unix_name = UnixName(self.name)
     self.source_file = source_file
     self.source_file_dir, self.source_file_filename = os.path.split(source_file)
     self.short_filename = os.path.basename(source_file).split('.')[0]
     self.parent = None
     self.platforms = _GetPlatforms(json)
     toplevel_origin = Origin(from_client=True, from_json=True)
     self.types = _GetTypes(self, json, self, toplevel_origin)
@@ skipping 471 matching lines @@
   # Sanity check: platforms should not be an empty list.
   if not json['platforms']:
     raise ValueError('"platforms" cannot be an empty list')
   platforms = []
   for platform_name in json['platforms']:
     for platform_enum in _Enum.GetAll(Platforms):
       if platform_name == platform_enum.name:
         platforms.append(platform_enum)
         break
   return platforms