Issue 487533004: Reverse swap order in DirectWrite typeface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 487533004: Reverse swap order in DirectWrite typeface. (Closed)

Created:
6 years, 4 months ago by bungeman-skia

Modified:
6 years, 4 months ago

Reviewers:
reed1

CC:
reviews_skia.org, mtklein, Nico

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Reverse swap order in DirectWrite typeface. C++ forbids temporaries to bind to non-const references. VC++ allows you to do so anyway, but it makes clang on Windows sad. Committed: https://skia.googlesource.com/skia/+/aace9976cddfa2f3e65f2ba263a5b66c7f0b923d

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ports/SkTypeface_win_dw.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/487533004/1

6 years, 4 months ago (2014-08-25 14:07:41 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-25 14:14:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as aace9976cddfa2f3e65f2ba263a5b66c7f0b923d